🎉 Celebrating 25 Years of GameDev.net! 🎉

Not many can claim 25 years on the Internet! Join us in celebrating this milestone. Learn more about our history, and thank you for being a part of our community!

Back to For Beginners

Where am I going wrong with this collision code?

Kyle Thomas · 2021-12-05T19:56:05

So I am a little confused with my code, I have got left and right collision to work but when it comes to colliding with the top and bottom, the player is thrown to the side of the enemy instead of being pushed back (please see the gif). Any help would be greatly appreciated. Here is the code that I am working with currently: void Player::CollisionChecker(Entity* otherEntity) { sf::FloatRect entityCol = otherEntity->collisionComponent()->getGlobalBounds(); sf::FloatRect playerCol = collisionComponent()->getGlobalBounds(); printf("%f, %f\n", oldBounds.width, oldBounds.left); if (playerCol.top + playerCol.height < entityCol.top || playerCol.top > entityCol.top + entityCol.height || playerCol.left + playerCol.width < entityCol.left || playerCol.left > entityCol.left + entityCol.width) return; if (playerCol.left + playerCol.width >= entityCol.left && GetPosition().x < entityCol.left) { SetPosition(entityCol.left - entityCol.width - 0.1f, GetPosition().y); _velocity.x = 0.f; } else if (playerCol.left <= entityCol.left + entityCol.width && GetPosition().x > entityCol.width) { SetPosition(entityCol.left + entityCol.width + 0.1f, GetPosition().y); _velocity.x = 0.f; } else if (playerCol.top + playerCol.height >= entityCol.top && GetPosition().y < entityCol.top) { SetPosition(GetPosition().x, entityCol.top - entityCol.height - 0.1f); _velocity.y = 0.f; } else if (playerCol.top <= entityCol.top + entityCol.height && GetPosition().y > entityCol.height) { SetPosition(GetPosition().x, entityCol.top + entityCol.height + 0.1f); _velocity.y = 0.f; } }